This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Pr/118 parseStack respects windows paths #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
LewisJEllis
approved these changes
Feb 8, 2017
test/raven.utils.js
Outdated
| frame.context_line.should.be.type('string'); | ||
| frame.context_line.trim().should.endWith('undeclared_function();'); | ||
| frame.post_context.should.be.an.instanceOf(Array); | ||
| done(); |
There was a problem hiding this comment.
Can we add an assertion here on what frame.in_app should be, and add a comment to the effect of part 4 of this comment explaining what's going on in this test? It's not initially obvious that this tests anything not existing before this PR.
Please consider the proposed change.The source code of the non-native stacktrace lines was never fetched on Windows machines. That's because isInternal was always resolving to true no matter what:
```js
isInternal = line.isNative() || (frame.filename[0] !== '/' && frame.filename[0] !== '.');
```
I added 2 small modifications:
1) the hardcoded separator ('/') has been replaced with path.sep (please refer to: https://nodejs.org/api/path.html#path_path_sep). That way the check is valid for all platforms: '/' for linux and '\\' for windows
2) an extra check has been added: frame.filename.indexOf(':\\') != 1
That way absolute paths on windows are considered non-native.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this on windows and osx and everything seems to be working correctly! thank you @stambata and @seanbriceland original PR: #118