feat(normalization): Use exposed device-class-synthesis feature flag …

…to gate device.class synthesis in light normalization (#1974)

Uses the exposed `organizations:device-class-synthesis` sentry feature
flag to gate synthesis of the `device.class` tag. This is a temporary
flag for managing rollout to EA users and eventually to be removed for
GA release.

CHANGELOG.md

@@ -36,6 +36,7 @@ Metrics:
 
 - Upgrade the web framework and related dependencies. ([#1938](https://github.com/getsentry/relay/pull/1938))
 - Apply transaction clustering rules before UUID scrubbing rules. ([#1964](https://github.com/getsentry/relay/pull/1964))
+- Use exposed device-class-synthesis feature flag to gate device.class synthesis in light normalization. ([#1974](https://github.com/getsentry/relay/pull/1974))
 - Use types from `sentry-kafka-schemas` crate to validate metrics messages into kafka. ([#1981](https://github.com/getsentry/relay/pull/1981))
 
 ## 23.3.1

relay-cabi/src/processing.rs

@@ -125,6 +125,7 @@ pub unsafe extern "C" fn relay_store_normalizer_normalize_event(
         normalize_user_agent: config.normalize_user_agent,
         transaction_name_config: Default::default(), // only supported in relay
         is_renormalize: config.is_renormalize.unwrap_or(false),
+        device_class_synthesis_config: false, // only supported in relay
     };
     light_normalize_event(&mut event, light_normalization_config)?;
     process_value(&mut event, &mut *processor, ProcessingState::root())?;

relay-dynamic-config/src/feature.rs

@@ -22,6 +22,11 @@ pub enum Feature {
     /// Transaction names modified by clusterer rules are always marked as such.
     #[serde(rename = "organizations:transaction-name-mark-scrubbed-as-sanitized")]
     TransactionNameMarkScrubbedAsSanitized,
+    /// Enables device.class synthesis
+    ///
+    /// Enables device.class tag synthesis on mobile events.
+    #[serde(rename = "organizations:device-class-synthesis")]
+    DeviceClassSynthesis,
     /// Unused.
     ///
     /// This used to control the initial experimental metrics extraction for sessions and has been

relay-general/src/store/normalize.rs

@@ -687,6 +687,7 @@ pub struct LightNormalizationConfig<'a> {
     pub normalize_user_agent: Option<bool>,
     pub transaction_name_config: TransactionNameConfig<'a>,
     pub is_renormalize: bool,
+    pub device_class_synthesis_config: bool,
 }
 
 pub fn light_normalize_event(
@@ -749,7 +750,11 @@ pub fn light_normalize_event(
             config.max_secs_in_future,
         )?; // Timestamps are core in the metrics extraction
         normalize_event_tags(event)?; // Tags are added to every metric
-        normalize_device_class(event);
+
+        // TODO: Consider moving to store normalization
+        if config.device_class_synthesis_config {
+            normalize_device_class(event);
+        }
         light_normalize_stacktraces(event)?;
         normalize_exceptions(event)?; // Browser extension filters look at the stacktrace
         normalize_user_agent(event, config.normalize_user_agent); // Legacy browsers filter

relay-server/src/actors/processor.rs

@@ -2222,7 +2222,9 @@ impl EnvelopeProcessorService {
                         .has_feature(Feature::TransactionNameMarkScrubbedAsSanitized),
                     rules: &state.project_state.config.tx_name_rules,
                 },
-
+                device_class_synthesis_config: state
+                    .project_state
+                    .has_feature(Feature::DeviceClassSynthesis),
                 is_renormalize: false,
             };