feat(normalization): Use exposed device-class-synthesis feature flag to gate device.class synthesis in light normalization #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+753
to
+755
| if config.device_class_synthesis_config { | ||
| normalize_device_class(event); | ||
| } |
There was a problem hiding this comment.
I assume this PR is related to #1970. This will only normalize device.class when the feature flag is enabled for the project, so the functionality your other PR does won't run for organizations with the feature flag disabled. It will also skip other functionality, so no device.class tags will exist on events. Is this what you want?
There was a problem hiding this comment.
Hi @iker-barriocanal , yup this is the effect we're looking for. We're starting to rollout device class to customers and we want to be able to turn off this functionality in case the classifications are wrong or something breaks.
iker-barriocanal
approved these changes
Mar 30, 2023
edwardgou-sentry
changed the title
edwardgou-sentry
changed the title
iker-barriocanal
approved these changes
Mar 31, 2023
…te-device-class-synthesis-by-exposed-flag
edwardgou-sentry
deleted the
egou/feat/gate-device-class-synthesis-by-exposed-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the exposed
organizations:device-class-synthesissentry feature flag to gate synthesis of thedevice.classtag. This is a temporary flag for managing rollout to EA users and eventually to be removed for GA release.