feat: Capture minidumps for hard crashes [INGEST-566] #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accidentally requested review instead of opening as Draft PR. Please ignore linter and linker errors for the time being. I would like to settle on the approach first and test it out before wrapping this up. |
jan-auer
changed the title
Swatinem
approved these changes
Nov 16, 2021
jan-auer
force-pushed
the
feat/native-crashes
branch
from
43e6a82
to
5531c0c
Compare
tonyo
approved these changes
Nov 24, 2021
* master: test(outcomes): Fix sort order in flaky test (#1135) feat(outcomes): Aggregate more outcomes (#1134) ref(outcomes): Fold processing vs non-processing into single actor (#1133) build: Update symbolic to support UE5 (#1132) feat(metrics): Extract measurement ratings, port from frontend (#1130) feat(metrics): Another statsd metric to measure bucket duplication (#1128) feat(outcomes): Emit outcomes as client reports (#1119) fix: Move changelog line to right version (#1129) fix(dangerjs): Do not suggest to add JIRA ticket to changelog (#1125) feat(metrics): Tag metrics by transaction name [INGEST-542] (#1126)
untitaker
reviewed
Nov 24, 2021
|
|
||
| #[cfg(not(unix))] | ||
| pub fn install(&self) { | ||
| unimplemented!("crash handler not supported on this platform"); |
There was a problem hiding this comment.
is it even possible to compile this module on windows?
There was a problem hiding this comment.
it's possible, sentry-native with breakpad works on Windows, too. Given this is fully internal, I just did not build this out in the build script (requires linking against a few other libraries).
untitaker
approved these changes
Nov 24, 2021
Good point. sentry-native deletes minidumps after handling them. |
oioki
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses sentry-native with the breakpad backend to offer an optional
crash-handlerfeature for Linux and macOS. When enabled, it'll capture hard crashes and write minidumps with stack traces of all threads into a database folder on the file system. On next restart, those crashes will be sent to Sentry for debugging. The DSN and release are inherited from the main Sentry SDK.Breakpad offers advantages over the other backends. First, it works on all major platforms we need to support. Second, it does not need a handler process. Third, it still captures memory dumps with all threads. In the long run, we'd probably opt for the in-house crash reporter without third-party crash reporters in pure rust.
The minidump will have to be persisted in a volume that survives container restarts. There is a new configuration
sentry._crash_dbfor this.cc @Swatinem @oioki