feat(transaction): Normalize transaction name #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding feature which, when enabled, supports transaction names normalization by replacing UUIDs, SHAs and numerical IDs in transaction names by placeholders. This is the first step which should help to prevent high cardinality for transaction names.
jjbayer
reviewed
Nov 23, 2022
relay-general/src/store/normalize.rs
Outdated
| @@ -663,6 +663,7 @@ pub struct LightNormalizationConfig<'a> { | |||
| pub measurements_config: Option<&'a MeasurementsConfig>, | |||
| pub breakdowns_config: Option<&'a BreakdownsConfig>, | |||
| pub normalize_user_agent: Option<bool>, | |||
| pub normalize_transaction_name: Option<bool>, | |||
There was a problem hiding this comment.
nit: Does this need to be an Option<bool>? I don't know why normalize_user_agent is one to be honest, I feel like a simple bool would do just fine.
| // ranges will change. | ||
| for matches in TRANSACTION_NAME_NORMALIZER_REGEX.captures_iter(trans) { | ||
| // Skip first, since it's always the entire match and the following are groups. | ||
| // And if there is no matches, just cotinue to next iteration. |
There was a problem hiding this comment.
Suggested change
| // And if there is no matches, just cotinue to next iteration. | |
| // And if there is no matches, just continue to next iteration. |
Comment on lines
244
to
245
| for name in capture_names { | ||
| if let Some(caps) = TRANSACTION_NAME_NORMALIZER_REGEX.captures(trans) { |
There was a problem hiding this comment.
Suggested change
| for name in capture_names { | |
| if let Some(caps) = TRANSACTION_NAME_NORMALIZER_REGEX.captures(trans) { | |
| if let Some(caps) = TRANSACTION_NAME_NORMALIZER_REGEX.captures(trans) { | |
| for name in capture_names { |
| if meta.original_value().is_none() { | ||
| meta.set_original_value(Some(trans.to_string())) | ||
| } | ||
| let mut collector = String::new(); |
There was a problem hiding this comment.
It should be possible to allocate a new String only once for each transaction name. Assuming that capture_names are ordered , we can start writing [0..m1.start()], then [m1.end()...m2.start()], etc.
| *trans = collector; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there no way we can unify the two for loops in this function?
Comment on lines
1415
to
1421
| [ | ||
| "normalize_transaction_name", | ||
| "s", | ||
| 51, | ||
| 54 | ||
| ] | ||
| ], |
jjbayer
approved these changes
Nov 23, 2022
relay-server/src/actors/project.rs
Outdated
| @@ -71,6 +71,9 @@ pub enum Feature { | |||
| /// Enables ingestion of Session Replays (Replay Recordings and Replay Events) | |||
| #[serde(rename = "organizations:session-replay")] | |||
| Replays, | |||
| /// docs | |||
There was a problem hiding this comment.
I knew you will see it! 😄
olksdr
added a commit
to getsentry/sentry
that referenced
this pull request
Nov 23, 2022
… names (#41642) See relay side in getsentry/relay#1621 where the new feature will be consumed. Once enabled, we will try to normalize the transaction names by replacing UUID, SHAs, numerical IDs with placeholders. ref: getsentry/relay#1597
jan-auer
added a commit
that referenced
this pull request
Nov 24, 2022
* master: chore(toolchain): Fix lint and test for beta toolchain (#1623) ref(system): Introduce a generic recipient type (#1622) feat(transaction): Normalize transaction name (#1621) feat(server): Track metrics for OpenTelemetry events (#1618) bug(replays): Increase reserved space in payload chunks (#1601) feat(protocol): Add OpenTelemetry Context (#1617)
6 tasks
jjbayer
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 19, 2023
Literal asterisks in transaction names (such as created by getsentry/relay#1621) should not be confused with the wildcard `*`, which for transaction name rules means "match and replace".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding feature which, when enabled, supports transaction names normalization by replacing UUIDs, SHAs and numerical IDs in transaction names by placeholders.
This is the first step which should help to prevent high cardinality for transaction names.
ref: #1597