Skip to content

Commit

Permalink
feat(transaction): Add feature to be able to enable normalization for…
Browse files Browse the repository at this point in the history
… names (#41642)

See relay side in getsentry/relay#1621 where the
new feature will be consumed.

Once enabled, we will try to normalize the transaction names by
replacing UUID, SHAs, numerical IDs with placeholders.

ref: getsentry/relay#1597
  • Loading branch information
olksdr committed Nov 23, 2022
1 parent 33066f4 commit 81337ea
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/sentry/conf/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,8 @@ def SOCIAL_AUTH_DEFAULT_USERNAME():
"organizations:metric-alert-chartcuterie": False,
# Extract metrics for sessions during ingestion.
"organizations:metrics-extraction": False,
# Normalize transaction names during ingestion.
"organizations:transaction-name-normalize": False,
# Extraction metrics for transactions during ingestion.
"organizations:transaction-metrics-extraction": False,
# Allow performance alerts to be created on the metrics dataset. Allows UI to switch between
Expand Down
1 change: 1 addition & 0 deletions src/sentry/features/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@
default_manager.add("organizations:slack-overage-notifications", OrganizationFeature, True)
default_manager.add("organizations:symbol-sources", OrganizationFeature)
default_manager.add("organizations:team-roles", OrganizationFeature, True)
default_manager.add("organizations:transaction-name-normalize", OrganizationFeature, True)
default_manager.add("organizations:transaction-metrics-extraction", OrganizationFeature)
default_manager.add("organizations:unified-span-view", OrganizationFeature, True)
default_manager.add("organizations:use-metrics-layer", OrganizationFeature, True)
Expand Down
6 changes: 5 additions & 1 deletion src/sentry/relay/config/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@
from .measurements import CUSTOM_MEASUREMENT_LIMIT, get_measurements_config

#: These features will be listed in the project config
EXPOSABLE_FEATURES = ["organizations:profiling", "organizations:session-replay"]
EXPOSABLE_FEATURES = [
"organizations:transaction-name-normalize",
"organizations:profiling",
"organizations:session-replay",
]

logger = logging.getLogger(__name__)

Expand Down

0 comments on commit 81337ea

Please sign in to comment.