Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transactions): Adding support for transaction (re)naming rules #1695

Merged
merged 17 commits into from
Dec 20, 2022
Merged

feat(transactions): Adding support for transaction (re)naming rules #1695

merged 17 commits into from
Dec 20, 2022

Commits on Dec 14, 2022

  1. Adding support for transaction (re)naming rules 

    These changes introduce the support for naming rules, which currently
can be applied to only `url` transaction source:

* relay always applys first matching rule
* rules applied in light normalization, before extraxting any
  information from the event
* original transaction name is preserved in meta, and also remark added
  with the rule, which was applied
* `transaction_info.source` is changed to `sanitized` after rule is
  applied

This PR also contains changes to the current implementation of `Glob`,
addint the ability to apply the matching rule to replace parts of the
matching pattern - which maybe could be done separatelly.

Also few existing structs were re-used / re-purposed to support new rule
format, which also up for the discussions.
    @olksdr
    olksdr committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d52fc21 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @olksdr
    olksdr committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    49ef92b View commit details
    Browse the repository at this point in the history

  3. feat(transaction): use / in transaction name to make globs work

    @olksdr
    olksdr committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    17c4ded View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Merge branch 'master' into feat/trans-renaming-rules

    @olksdr
    olksdr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8b27e09 View commit details
    Browse the repository at this point in the history

  2. feat(transactions): Add builder to Glob and custom deserializer for G… 

    …lob in txname rule
    @olksdr
    olksdr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    b90a8ba View commit details
    Browse the repository at this point in the history

  3. Remove serde default from RedactionRule

    @olksdr
    olksdr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    967f2ed View commit details
    Browse the repository at this point in the history

  4. Rearrange the code, log the trace for the wrong reduction type

    @olksdr
    olksdr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5a5b1ca View commit details
    Browse the repository at this point in the history

  5. Address review comments

    @olksdr
    olksdr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    53d59a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Merge branch 'master' into feat/trans-renaming-rules

    @olksdr
    olksdr committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    642833c View commit details
    Browse the repository at this point in the history

  2. Address some review comments

    @olksdr
    olksdr committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ffc24c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Add roundtrip serialize/deserialize test

    @olksdr
    olksdr committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    180e930 View commit details
    Browse the repository at this point in the history

  2. Clean up function args

    @olksdr
    olksdr committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    689a08b View commit details
    Browse the repository at this point in the history

  3. fix lint

    @olksdr
    olksdr committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    0a6af11 View commit details
    Browse the repository at this point in the history

  4. Address review comments

    @olksdr
    olksdr committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    fc1a2f9 View commit details
    Browse the repository at this point in the history

  5. Add more tests for captures replace

    @olksdr
    olksdr committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    596f3db View commit details
    Browse the repository at this point in the history

  6. Use Cow on transaction name

    @olksdr
    olksdr committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    8199c5c View commit details
    Browse the repository at this point in the history

  7. Use "ends_with" on string

    @olksdr
    olksdr committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    33fed75 View commit details
    Browse the repository at this point in the history