Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(normalization): Use exposed device-class-synthesis feature flag to gate device.class synthesis in light normalization #1974
feat(normalization): Use exposed device-class-synthesis feature flag to gate device.class synthesis in light normalization #1974
Changes from 5 commits
3744987
221eccb
2cc9aa3
2ee9b4a
6417b77
efad34c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this PR is related to #1970. This will only normalize
device.class
when the feature flag is enabled for the project, so the functionality your other PR does won't run for organizations with the feature flag disabled. It will also skip other functionality, so nodevice.class
tags will exist on events. Is this what you want?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @iker-barriocanal , yup this is the effect we're looking for. We're starting to rollout device class to customers and we want to be able to turn off this functionality in case the classifications are wrong or something breaks.