feat(protocol): Change lock_reason to a held_locks dictionary #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah, ok, it's here https://develop.sentry.dev/rust/#development-environment, should I remove it from the readme then? |
shruthilayaj
approved these changes
Apr 12, 2023
iker-barriocanal
approved these changes
Apr 12, 2023
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thread can hold multiple locks, so this PR changes the recently introduced
lock_reasonattribute to a dictionary/map, where the key is the lock object address and the value is the existingLockReasonstruct. I was also thinking to make it just an Array, but I think it'd be easier and faster to look up by a lock address when we analyze.Additionally, I haven't found any docs about how to update snapshot files, so I've added a section to readme about that, lemme know if that makes sense.
https://cs.android.com/android/platform/superproject/+/master:development/tools/bugreport/src/com/android/bugreport/stacks/ThreadSnapshot.java;l=53