feat(protocol): Add lock attribute to the frame protocol #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2094 This PR ensures relay can also use the `x-vercel-forwarded-for` header, and preferring this when also `x-forwarded-for` is also present. Made a small refactor for the sake of writing unit tests. Also fixed some linting errors that were introduced to relay 2 weeks ago, not sure how it passed CI. --------- Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
Consider `"`s in an SQL query to extract the domain, aka table name.
7 tasks
olksdr
approved these changes
Jun 2, 2023
|
@romtsn please don't forget to update develop docs! |
that's on my list, but thanks for the reminder nonetheless :) |
|
@olksdr @iker-barriocanal hmm, did I also have to add an entry to |
|
@romtsn yep, you can refer to relay changelog instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in addition to #2018 to highlight the offending frame in the UI, so the lock has to be also on the per-frame level.
Also fixed the changelog for #2124 as it sneaked into the previous release, although hasn't been part of it.