fix(crons): Limit environment names on check-ins to 64 chars

[rjo100]

Restricts max_chars on environment names.

Helps close SENTRY-1351

#skip-changelog

[jjbayer]

The metastructure attribute only works in combination with Annotated. I think we need to do some manual work here, similar to trim_slug.

[rjo100]

is there any way to directly import this value instead? can add in the copycat trim_slug after

relay/relay-general/src/processor/attrs.rs

Line 134 in 3ec78a1

MaxChars::Environment => 64,

[jjbayer]

is there any way to directly import this value instead? can add in the copycat trim_slug after

relay/relay-general/src/processor/attrs.rs

Line 134 in 3ec78a1

MaxChars::Environment => 64,

You can either add relay-general to this crate's Cargo.toml and then use MaxChars::Environment.limit(), or (to avoid an additional dependency), define a new constant in relay-common and import it from both here and MaxChars::limit().

[jjbayer]

Almost there, see two remaining comments.

[olksdr]

Left few suggestions.

I'm not sure we want to rely on relay-general crate though, it's quite big with a lot of deps as well, and it would be better to keep the relay-monitors somewhere with smaller footprint.

[olksdr]

Could you, please, move this to Unreleased section of the changelog

[rjo100]

Yep, got moved during a bad merge

[olksdr]

Suggested change

	/// Environment name was invalid.environment.
	/// Environment name was invalid.

[rjo100]

I really want to only import the environment max chars length to keep everything synced up to one variable as it represents the same object. I can manually copy the 64 limit over but would prefer not to.

[jjbayer]

I really want to only import the environment max chars length to keep everything synced up to one variable as it represents the same object. I can manually copy the 64 limit over but would prefer not to.

How about we define a constant in relay-common and import it from both places (relay-general and relay-monitors)?

[rjo100]

I think I'm just going to hardcode 64 in relay-monitors and update this comment in the sentry repo mention both instances

[rjo100]

alright I can't figure out how to make this work. will wait for comments

[jjbayer]

LGTM as-is.