feat(cardinality): Implement cardinality reporting #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/ref/pipeline-card
branch
from
77ad55b
to
021cd65
Compare
Dav1dde
force-pushed
the
dav1d/ref/card-reports
branch
2 times, most recently
from
d7e8de0
to
0bcb7ff
Compare
Dav1dde
force-pushed
the
dav1d/ref/card-reports
branch
from
0bcb7ff
to
8a8f404
Compare
iker-barriocanal
approved these changes
Mar 28, 2024
Comment on lines
+54
to
+55
| /// The callback can be called multiple times with different reports | ||
| /// for the same `limit` or not at all if there was no change in cardinality. |
There was a problem hiding this comment.
there was no change in cardinality.
What does that mean? Is this function called only when going to redis and not when using a cache?
There was a problem hiding this comment.
Exactly! Which comes down to, it is valid to only call the callback when the actual cardinality in the window increased.
jjbayer
approved these changes
Mar 28, 2024
relay-cardinality/src/limiter.rs
Outdated
Comment on lines
217
to
218
| limits: HashSet<&'a CardinalityLimit>, | ||
| reports: BTreeMap<&'a CardinalityLimit, Vec<CardinalityReport>>, |
There was a problem hiding this comment.
Could this be a single map instead of a hash set and a btreemap, with an empty Vec if limit.report is false?
There was a problem hiding this comment.
I just implemented it, but I it's actually wrong. There can be cardinality reports for limits which have not been exceeded.
I'll revert and rename the field to make it more clear!
Dav1dde
force-pushed
the
dav1d/ref/card-reports
branch
from
859cfdb
to
0473d8c
Compare
jan-auer
added a commit
that referenced
this pull request
Apr 3, 2024
* master: feat(metric-stats): Report cardinality to metric stats (#3360) release: 0.8.56 fix(perfscore): Adds span op tag to perf score totals (#3326) ref(profiles): Return retention_days as part of the Kafka message (#3362) ref(filter): Add GTmetrix to the list of web crawlers (#3363) fix: Fix kafka topic default (#3350) ref(normalization): Remove duplicated normalization (#3355) feat(feedback): Emit outcomes for user feedback events (#3026) feat(cardinality): Implement cardinality reporting (#3342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the cardinality limiter able to report cardinality per "sub"-scope and return the collected information.
Cardinality Limits can now opt-in into recording/reporting cardinality per limit/generated scope. The reports will be accumulated and exposed through the
CardinalityResult.The collected reports are not yet used in Relay, it's a preparation to use the reports in a followup:
#skip-changelog