feat(metric-stats): Report cardinality to metric stats #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-cardinality
branch
from
d35eaa8
to
61221e9
Compare
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-cardinality
branch
from
61221e9
to
94cb3df
Compare
relay-server/src/metric_stats.rs
Outdated
| @@ -66,6 +77,35 @@ impl MetricStats { | |||
| .send(MergeBuckets::new(scoping.project_key, vec![volume])); | |||
| } | |||
|
|
|||
| /// Tracks the cardinality of a metric. | |||
| pub fn cardinality( | |||
There was a problem hiding this comment.
Wdyt about track_cardinality? I find it more predictable from the API's user pov, even if it's similar to the track above.
There was a problem hiding this comment.
+1, I left a similar comment here: https://github.com/getsentry/relay/pull/3342/files#r1542984095
There was a problem hiding this comment.
@jjbayer sorry, I remember renaming it not sure what happened to it :(
jjbayer
approved these changes
Apr 2, 2024
relay-server/src/metric_stats.rs
Outdated
| @@ -66,6 +77,35 @@ impl MetricStats { | |||
| .send(MergeBuckets::new(scoping.project_key, vec![volume])); | |||
| } | |||
|
|
|||
| /// Tracks the cardinality of a metric. | |||
| pub fn cardinality( | |||
There was a problem hiding this comment.
+1, I left a similar comment here: https://github.com/getsentry/relay/pull/3342/files#r1542984095
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-cardinality
branch
from
c75d8ca
to
239e000
Compare
jan-auer
added a commit
that referenced
this pull request
Apr 3, 2024
* master: feat(metric-stats): Report cardinality to metric stats (#3360) release: 0.8.56 fix(perfscore): Adds span op tag to perf score totals (#3326) ref(profiles): Return retention_days as part of the Kafka message (#3362) ref(filter): Add GTmetrix to the list of web crawlers (#3363) fix: Fix kafka topic default (#3350) ref(normalization): Remove duplicated normalization (#3355) feat(feedback): Emit outcomes for user feedback events (#3026) feat(cardinality): Implement cardinality reporting (#3342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emits collected cardinality reports as metric stats.
Changed cardinality limit to a
u32, this is still way too big for us ever to reach it, but it makes the conversion to f64 easier.