Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta(readme): Document development config for processing mode #921

Merged
merged 3 commits into from
Feb 11, 2021
Merged

meta(readme): Document development config for processing mode #921

merged 3 commits into from
Feb 11, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Feb 9, 2021

#skip-changelog

@jan-auer jan-auer requested a review from a team February 9, 2021 11:15
@jan-auer
Copy link
Member Author

jan-auer commented Feb 9, 2021

cc @RyanSkonnord @leedongwei @JoshFerge

@jan-auer
Merge branch 'master' into meta/processing-readme
4a9ffa0 
* master:
  fix(ci): Use loopback ip for advertised listeners (#922)
untitaker
untitaker approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the context is but this sounds about right

however processing relay is already part of sentry devservices. it may be simpler to edit relay/config.yml in the sentry repo (that is checked in) and restart the devserver.

@jan-auer
Copy link
Member Author

jan-auer commented Feb 11, 2021 •
edited
Loading

@untitaker Thanks, I'll clarify. Note that this section is part of "Development". This is for developing processing mode, where you can't use the pre-built Docker container. Devservices essentially uses this configuration already.

@jan-auer jan-auer merged commit 8266d5c into master Feb 11, 2021
@jan-auer jan-auer deleted the meta/processing-readme branch February 11, 2021 12:28
jan-auer added a commit that referenced this pull request Feb 26, 2021
@jan-auer
Merge branch 'master' into release/docker-openssl-vendored
ae36f35 
* master: (23 commits)
  feat(server): Add inbound filters functionality to dynamic sampling (#920)
  fix rule generation to new format (in tests) (#939)
  ref: Remove actix-web client, make reqwest the new http client (#938)
  fix(server): Reject empty envelopes with an explicit error (#937)
  fix(server): Ensure outcome data categories are numeric (#936)
  feat(stats): Add data category to TrackOutcome (#931)
  fix(pii): Make username pii-strippable (#935)
  build: Bump symbolic to 8.0.4 (#899)
  fix: Update to tokio 1.0 (#909)
  fix(pii): Make and/or work correctly with pii=maybe (#932)
  release: 21.2.0
  release: 0.8.3
  fix(build): Fix path to 3.7 (#930)
  build: drop python 2.7 support (#929)
  feat(protocol): Add snapshot to the stack trace interface (#927)
  test: Improve integration tests to reduce flakyness (#928)
  fix: Ignore false-positive lints from Clippy 1.50 (#926)
  feat(protocol): Add NSError to mechanism (#925)
  meta: Fix changelog
  meta(readme): Document development config for processing mode (#921)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-auer @untitaker