expose get_registry() method #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2067 2067
=========================================
Hits 2067 2067
Continue to review full report at Codecov.
|
markstory
reviewed
Jan 18, 2022
| @@ -482,20 +482,26 @@ Example that shows how to set custom registry | |||
| pass | |||
|
|
|||
|
|
|||
| print("Before tests:", responses.mock.get_registry()) | |||
There was a problem hiding this comment.
we can, but why?
I think this is a good example to show how to check registry type
|
Looks good but there are some conflicts that need to be fixed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #475
@markstory
we can consider backing up
_get_registry()and complimenting it withget_registry()or just replacing the methodbasically, it is an internal API now, so we can go straight with replacement, or we just do it extra safe