mbeliaev/assert call count #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`remove` method returns list of removed responses. Update `add` method on `FirstMatchRegistry` object to do a deepcopy if the same in-memory object is already in the list.
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2320 2347 +27
=========================================
+ Hits 2320 2347 +27
Continue to review full report at Codecov.
|
markstory
reviewed
Mar 31, 2022
|
|
||
| def delete(self, *args, **kwargs): | ||
| self.add(DELETE, *args, **kwargs) | ||
| return self.add(DELETE, *args, **kwargs) |
There was a problem hiding this comment.
Should we be updating the typehint/signature on these methods to include the new return value?
There was a problem hiding this comment.
@markstory
done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #335
Considering evolved functionality of
matchersI do not see it valuable to continue expandingassert_call_count. I believe more preferable will be to inspectResponseobjects, since they include matchers and all further functionality