Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose a new way to expose the handled property #15

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Propose a new way to expose the handled property #15

merged 5 commits into from
Oct 25, 2022

Conversation

cleptric
Copy link
Member

This RFC proposes a new way to expose the handled property to a user.

Rendered RFC

@cleptric cleptric self-assigned this Sep 26, 2022
@lforst lforst self-requested a review September 27, 2022 12:55
@marandaneto
Copy link
Contributor

Before we go ahead with this change, in case we wanna align that for the unified API, lets also discuss #10

@marandaneto marandaneto mentioned this pull request Sep 28, 2022
Open
vladanpaunovic
vladanpaunovic reviewed Sep 30, 2022
View reviewed changes
Copy link

@vladanpaunovic vladanpaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After considering proposed options, my vote goes to

Add bool $handled = true as an optional parameter to captureException()

text/0015-expose-handeled-property.md Show resolved Hide resolved
text/0015-expose-handeled-property.md Outdated Show resolved Hide resolved
@cleptric
Copy link
Member Author

What most SDKs do here is to create a new SentryEvent, with a mechanism and handled=false and instead of calling captureException, they call captureEvent, is that even possible?

So after picking around in the PHP SDK, I came to the conclusion that this would be the best option to move forward.

getsentry/sentry-php#1416

Due to some BC issues, I "hacked" it in, but it works fine for now.
Shall we use this RFC as a conclusion that SDKs should take this path or shall we close it?

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Oct 24, 2022 •
edited

Shall we use this RFC as a conclusion that SDKs should take this path or shall we close it?

I'm in favour of this updating the RFC around this - exposing the mechanism in the hint is a pretty clean pattern + works with event processors.

@cleptric
Copy link
Member Author

This is ready to be merged. Pls add your ✅

vladanpaunovic
vladanpaunovic approved these changes Oct 25, 2022
View reviewed changes
Copy link

@vladanpaunovic vladanpaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cleptric cleptric merged commit e165593 into main Oct 25, 2022
@cleptric cleptric deleted the expose-handled branch October 25, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker left review comments

@marandaneto marandaneto marandaneto left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@vladanpaunovic vladanpaunovic vladanpaunovic approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

@jan-auer jan-auer Awaiting requested review from jan-auer

@lforst lforst Awaiting requested review from lforst

Assignees

@cleptric cleptric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cleptric @marandaneto @AbhiPrasad @antonpirker @vladanpaunovic