fix: textarea duplicate values

+ add tests
getsentry · Feb 23, 2023 · f7fec59 · f7fec59
1 parent 1cb2ec9
commit f7fec59
Show file tree

Hide file tree

Showing 5 changed files with 1,644 additions and 47 deletions.
diff --git a/packages/rrweb-snapshot/src/snapshot.ts b/packages/rrweb-snapshot/src/snapshot.ts
@@ -543,10 +543,9 @@ function serializeNode(
       // form fields
       if (
         tagName === 'input' ||
-        tagName === 'textarea' ||
         tagName === 'select'
       ) {
-        const value = (n as HTMLInputElement | HTMLTextAreaElement).value;
+        const value = (n as HTMLInputElement).value;
         if (
           attributes.type !== 'radio' &&
           attributes.type !== 'checkbox' &&
@@ -1249,4 +1248,4 @@ export default snapshot;
 /** We want to skip `autoplay` attribute, as this has weird results when replaying.  */
 function skipAttribute(tagName: string, attributeName: string, value?: unknown) {
   return (tagName === 'video' || tagName === 'audio') && attributeName === 'autoplay';
-}
+}
diff --git a/packages/rrweb-snapshot/src/utils.ts b/packages/rrweb-snapshot/src/utils.ts
@@ -37,6 +37,7 @@ export function maskInputValue({
   if (
     maskInputOptions[tagName.toLowerCase() as keyof MaskInputOptions] ||
     maskInputOptions[type as keyof MaskInputOptions] ||
+    (tagName === 'input' && !type && maskInputOptions['text']) || // For inputs without a "type" attribute defined
     (maskInputSelector && input.matches(maskInputSelector))
   ) {
     if (maskInputFn) {