ref: Avoid async in canvas #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/avoid-await
branch
from
d20a88f
to
9ef2944
Compare
billyvg
approved these changes
Dec 19, 2023
| ); | ||
| }) | ||
| .catch(() => { | ||
| // noop |
There was a problem hiding this comment.
We should probably bubble this up to the error handler
There was a problem hiding this comment.
Hmm, looking at https://developer.mozilla.org/en-US/docs/Web/API/createImageBitmap it doesn't seem as if that should reject 🤔 I guess we can re-throw this in the callbackWrapper, to be sure 🤔
mydea
force-pushed
the
fn/avoid-await
branch
from
9ef2944
to
01b7528
Compare
mydea
commented
Dec 20, 2023
| ); | ||
| }) | ||
| .catch((error) => { | ||
| callbackWrapper(() => {throw error}); |
mydea
force-pushed
the
fn/avoid-await
branch
from
ea37fb2
to
cddf05b
Compare
mydea
force-pushed
the
fn/avoid-await
branch
from
cddf05b
to
0ee7397
Compare
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 10, 2024
This bump contains the following changes: - fix(rrweb): Use unpatched requestAnimationFrame when possible [#150](getsentry/rrweb#150) - ref: Avoid async in canvas [#143](getsentry/rrweb#143) - feat: Bundle canvas worker manually [#144](getsentry/rrweb#144) - build: Build for ES2020 [#142](getsentry/rrweb#142) Extracted out from #9826 Closes #6946
billyvg
pushed a commit
that referenced
this pull request
Apr 26, 2024
Related to #142, noticed that this is kind of unnecessary (and is transpiled in pre-ES2017 envs). Passing an async function to forEach is anyhow a bit weird I'd say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #142, noticed that this is kind of unnecessary (and is transpiled in pre-ES2017 envs). Passing an async function to forEach is anyhow a bit weird I'd say.