fix: Protect against matches() being undefined
#154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)
billyvg
force-pushed
the
fix-el-matches-undefined
branch
from
1ff656f
to
6c189bd
Compare
size-limit report 📦
|
c298lee
approved these changes
Jan 10, 2024
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try/catch to protect against cases where
el.matchesis not a function (not sure exact cause, but possiblyelis undefined, or not an Element type)