Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: Extended text masking function to include relevant HTMLElement #164

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 31, 2024

  • Extends maskTextFn to pass the HTMLElement to the deciding function

Authored-by: benjackwhite benjackwhite@users.noreply.github.com
Co-authored-by: Justin Halsall Juice10@users.noreply.github.com
Co-authored-by: Eoghan Murray eoghan@getthere.ie

…-io#1310)

* Extends maskTextFn to pass the HTMLElement to the deciding function

---------

Authored-by: benjackwhite <benjackwhite@users.noreply.github.com>
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
@billyvg
Copy link
Member Author

billyvg commented Jan 31, 2024

Ref rrweb-io#1310

Copy link

github-actions bot commented Jan 31, 2024

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.82 KB (+0.12% 🔺)
rrweb - record & CanvasManager only (gzipped) 19.63 KB (+0.12% 🔺)
rrweb - record only (min) 57.3 KB (+0.11% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.62 KB (+0.14% 🔺)

@billyvg billyvg marked this pull request as ready for review January 31, 2024 21:03
@billyvg billyvg requested a review from a team April 19, 2024 14:03
@billyvg billyvg changed the title Extended text masking function to include relevant HTMLElement (#1310) upstream: Extended text masking function to include relevant HTMLElement Apr 19, 2024
@billyvg billyvg merged commit 15c4677 into sentry-v2 Apr 19, 2024
14 checks passed
@billyvg billyvg deleted the sentry-v2-upstream-mask-text-fn-element branch April 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants