Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): CI test regularly dies with "Pool is closed" #823

Closed
chadwhitacre opened this issue Jan 19, 2021 · 1 comment · Fixed by #825 or #826
Closed

ci(test): CI test regularly dies with "Pool is closed" #823

chadwhitacre opened this issue Jan 19, 2021 · 1 comment · Fixed by #825 or #826
Assignees

Comments

@chadwhitacre
Copy link
Member

Attempted to fix in #768, etc. Still not resolved.

@BYK
Copy link
Member

BYK commented Jan 19, 2021

We also tried #819 which should help. Let's keep pushing on that direction?

@BYK BYK self-assigned this Jan 19, 2021
@BYK BYK changed the title meta: CI regularly dies with "Pool is closed" ci(test): CI test regularly dies with "Pool is closed" Jan 19, 2021
BYK added a commit that referenced this issue Jan 19, 2021
@BYK BYK closed this as completed in #825 Jan 19, 2021
BYK added a commit that referenced this issue Jan 19, 2021
@chadwhitacre chadwhitacre reopened this Jan 19, 2021
BYK added a commit that referenced this issue Jan 19, 2021
Fixes #823. In `install.sh` we build a local sentry image that is used by many services from using the build context under the `./sentry` directory. To avoid building this image multiple times, we also give it a specific name which is referred from multiple services. The issue is, we also run `docker-compose build --parallel` which creates a race condition when building this image as `docker-compose` doesn't check whether the image is already there or not. This is the root cause of all these random failures: an unsurprising race condition.
@BYK BYK closed this as completed in #826 Jan 19, 2021
BYK added a commit that referenced this issue Jan 19, 2021
Fixes #823. In `install.sh` we build a local sentry image that is used by many services from using the build context under the `./sentry` directory. To avoid building this image multiple times, we also give it a specific name which is referred from multiple services. The issue is, we also run `docker-compose build --parallel` which creates a race condition when building this image as `docker-compose` doesn't check whether the image is already there or not. This is the root cause of all these random failures: an unsurprising race condition.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants