Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfrobulate CI #768

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Unfrobulate CI #768

merged 4 commits into from
Jan 8, 2021

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Dec 10, 2020

Haven't gotten a clean test run yet over on #766. Time to investigate ...

@chadwhitacre
Copy link
Member Author

😏

Screen Shot 2020-12-11 at 3 05 58 PM

docker/compose#3586

@chadwhitacre chadwhitacre changed the title Testing Unfrobulate CI Dec 11, 2020
@chadwhitacre
Copy link
Member Author

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@chadwhitacre
Copy link
Member Author

Not sure what the solution is tho, we may try to reduce the concurrency again and see what happens

@BYK
Copy link
Member

BYK commented Jan 7, 2021

Seems like what I did helps but slows things down a bit. WDYT @chadwhitacre, acceptable?

@chadwhitacre
Copy link
Member Author

slow and working > fast and broken

@chadwhitacre
Copy link
Member Author

slow and working > fast and flakey > never-ending 😩

@BYK
Copy link
Member

BYK commented Jan 8, 2021

Okay, this seems to have fixed it. I'll re run the checks and see if this holds.

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Jan 8, 2021

Still failing with "Pool is closed." 😞

giphy

@chadwhitacre chadwhitacre merged commit 4399fc8 into master Jan 8, 2021
@chadwhitacre chadwhitacre deleted the chadwhitacre/test-ci branch January 8, 2021 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants