Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable crons #2712

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Enable crons #2712

merged 1 commit into from
Jan 16, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jan 16, 2024

This PR does a few things to enable crons in self-hosted.

  1. feature flag flipped on for crons
  2. ingest consumer added for crons
  3. crons kafka topic added

closes #1993

@hubertdeng123 hubertdeng123 requested review from azaslavsky and a team January 16, 2024 18:29
Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be all that is necessary

@hubertdeng123 hubertdeng123 enabled auto-merge (squash) January 16, 2024 21:11
@hubertdeng123 hubertdeng123 merged commit 5c7c192 into master Jan 16, 2024
8 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/enable-crons branch January 16, 2024 21:31
@jaydrogers
Copy link

Thanks for making this available!

Is there anything else that would be required to enable the cron feature? I just upgraded from 23.12 to 24.1 and I am not seeing it.

Can open another issue if needed, but just didn't know if this was a simple answer or not.

image

@sertxudev
Copy link

@jaydrogers I've edited the sentry/sentry.conf.py file to match the changes in the PR

            "organizations:session-replay",
            "organizations:issue-platform",
            "organizations:profiling",
+            "organizations:monitors",
            "organizations:dashboards-mep",
            "organizations:mep-rollout-flag",
            "organizations:dashboards-rh-widget",

@jaydrogers
Copy link

Wow, I forgot about this file. This solved my problem. ✅

Thanks for sharing @sertxudev!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Crons
5 participants