feat(generic-metrics): Add gauges to docker compose file #2757
Conversation
| @@ -283,6 +287,9 @@ services: | |||
| snuba-generic-metrics-counters-consumer: | |||
| <<: *snuba_defaults | |||
| command: consumer --storage generic_metrics_counters_raw --consumer-group snuba-gen-metrics-counters-consumers --auto-offset-reset=latest --max-batch-time-ms 750 --no-strict-offset-reset | |||
| snuba-generic-metrics-gauges-consumer: | |||
There was a problem hiding this comment.
is this a new consumer that was missed? 😅
There was a problem hiding this comment.
I know that this is missing and as far as I know, this is only used by the DDM backend? If that's the case, can we hold this until DDM is at least in beta or GA?
Adding a new container to the compose file is... an undesirable thing to do for self-hosted Sentry.
There was a problem hiding this comment.
If this is only used for DDM, I agree with @aldy505 that we should hold off on this for now
|
Since a lot of people are bound to run into this issue while trying to run metrics on self-hosted, would it be possible/acceptable to add it as a comment at least? So as to inform users that if they want to use DDM, they need to add the additional consumer to their docker-compose file. |
@ale-cota The self-hosted community never do that. For new features we always put an issue and point people to run/enable some things on their config in order to enable a new feature. For this specific issue, it's here: #2698 For other features, see #2646, #1993 (comment), and.. I forgot where is the issue for Performance Queries |
I like using a GitHub issue for this. Let's start formalizing that as our process. I've added a @Ale Can you help us share #2698 with customers who are interested trying out Metrics in self-hosted? @ayirr7 I'm gonna close this PR. 🙏 |
This was missing by default, adding this consumer to the docker-compose file as well