Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(setup): Rename config to SENTRY_TRUSTED_RELAY_PKS #535

Closed
wants to merge 1 commit into from

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jun 9, 2020

Renames the setting for trusted Relays to more sensitive language.

Requires getsentry/sentry#19240

@jan-auer jan-auer requested a review from BYK June 9, 2020 11:30
@jan-auer
Copy link
Member Author

jan-auer commented Jun 9, 2020

@BYK please let me know if you'd like to have both as a transition phase. Since there was no release since introducing Relay, however, I'd say we can just change this.

Copy link
Collaborator

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my feedback on getsentry/sentry#19240, let's refactor this to use config.yml. We may need to add some more migration code for this and I'm willing to takeover the onpremise part of this patch.

@BYK
Copy link
Collaborator

BYK commented Jul 10, 2020

This is now obsolete with #572 so closing.

@BYK BYK closed this Jul 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
@BYK BYK deleted the ref/rename-relay-whitelist branch April 15, 2021 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants