ref(config): Rename config to SENTRY_TRUSTED_RELAY_PKS

[jan-auer]

Renames the setting for trusted Relays to more sensitive language.

Requires https://github.com/getsentry/getsentry/pull/3988

[jan-auer]

Ok, onpremise needs updating, too.

[BYK]

Let's do something like a48d4c1 where we both deprecate this old setting and also move it into config.yml.

[jan-auer]

Is there any benefit we get from moving it? There are plenty of other related settings in the python file, such as SENTRY_RELAY_OPEN_REGISTRATION which we'd all have to move.

Edit: It generally seems that all of the settings that are similar to this one are in the Python file. I'm only asking as I'd like to keep this patch as straight-forward as possible.

[BYK]

Is there any benefit we get from moving it?

• You get automatic backwards compatibility (and the GCB build here would be fixed)
• Most of the customizable config is already moved to config.yml file and although there isn't a concerted effort behind this, we state that sentry.conf.py file is mostly deprecated

There are plenty of other related settings in the python file, such as SENTRY_RELAY_OPEN_REGISTRATION which we'd all have to move.

We can do them one by one (or in this PR, doesn't matter much) under a relay.* namespace.

[jan-auer]

Most of the customizable config is already moved to config.yml

I see. In that case, I'll give this a spin later.

we state that sentry.conf.py file is mostly deprecated

I think we should start adding large comments in server.py so that folks don't add more settings to that file. I still see new settings being added every now and then, although it has reduced over the last years.

[mitsuhiko]

This setting was never supposed to be set by non sentry.io installations. We expose this setting on a per-org basis in the org settings to enable external relays.

If we think there is a value to have this config be set by other parties than us I think we can move it, but that was not the original motivation at least.

[jan-auer]

Discussed offline a bit more, and we'll move to config.yml since this is required in the onpremise setup flow to get internal Relays working.

[BYK]

Closing due to staleness and conflicts.