Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto instrument OkHttp client with SentryOkHttpEventListener #477

Closed
stefanosiano opened this issue Apr 21, 2023 · 3 comments
Closed

Auto instrument OkHttp client with SentryOkHttpEventListener #477

stefanosiano opened this issue Apr 21, 2023 · 3 comments

Comments

@stefanosiano
Copy link
Member

Description

Once the SentryOkHttpEventListener pr is merged, we could autoinstrument the OkHttp clients with it, other than the SentryOkHttpInterceptor.
The only thing to take care of is that OkHttp allows only one EventListener at a time, so we shouldn't add ours if the user already set one.
We can do this by either changing the default OkHttpClient.Builder constructor and inject our listener or by using a wrapper around it

@markushi
Copy link
Member

markushi commented May 3, 2023

Ideally we would use both, the existing interceptor (for adding trace headers) and the event listener.

@kahest
Copy link
Member

kahest commented Jun 13, 2023

@stefanosiano has this been resolved with #504 and #508?

@romtsn
Copy link
Member

romtsn commented Jun 13, 2023

Closed by #504

@romtsn romtsn closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants