Add SentryOkHttpEventListener automatically #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stefanosiano
changed the title
fixed unit test
# Conflicts: # plugin-build/src/test/kotlin/io/sentry/android/gradle/SentryPluginTest.kt
fixed unit test
markushi
approved these changes
Jun 9, 2023
.../io/sentry/android/gradle/instrumentation/okhttp/visitor/OkHttpEventListenerMethodVisitor.kt
Outdated
Show resolved
Hide resolved
stefanosiano
commented
Jun 9, 2023
romtsn
reviewed
Jun 12, 2023
...ld/src/main/kotlin/io/sentry/android/gradle/instrumentation/SpanAddingClassVisitorFactory.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added SentryOkHttpEventListener automatic instrumentation when using the OkHttp feature
💡 Motivation and Context
We want to improve the coverage of the http spans when using OkHttp, using the new SentryOkHttpEventListener added in getsentry/sentry-java#2659
💚 How did you test it?
📝 Checklist
🔮 Next steps