Add OkHttp event spans

[stefanosiano]

📜 Description

added SentryOkHttpEventListener that creates a span on every OkHttp event
added SentryOkHttpEvent

Here is an example of the result.

💡 Motivation and Context

We are increasing the information shown to the user by adding spans for OkHttp events, including dns, https setup, proxies, request headers/body and response headers/body

💚 How did you test it?

Unit test

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Update docs https://docs.sentry.io/platforms/android/configuration/integrations/okhttp/

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 247ceb3

[stefanosiano]

I just need a confirmation if some data could be seen as PII

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	303.78 ms	336.69 ms	32.91 ms
Size	1.72 MiB	2.28 MiB	570.91 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
46b1782	387.72 ms	458.74 ms	71.02 ms
1707044	338.80 ms	384.79 ms	46.00 ms

App size

Revision	Plain	With Sentry	Diff
46b1782	1.72 MiB	2.28 MiB	570.44 KiB
1707044	1.72 MiB	2.28 MiB	570.44 KiB

Previous results on branch: feat/okhttp-event-spans

Startup times

Revision	Plain	With Sentry	Diff
6244bee	244.04 ms	390.08 ms	146.04 ms
80dcf36	311.78 ms	350.02 ms	38.24 ms
418cd6d	339.98 ms	381.98 ms	42.00 ms
19b506b	386.54 ms	413.02 ms	26.48 ms
4e5eb0c	357.83 ms	363.70 ms	5.87 ms
f79cd6a	295.88 ms	358.24 ms	62.36 ms
f08b219	320.40 ms	372.40 ms	52.00 ms

App size

Revision	Plain	With Sentry	Diff
6244bee	1.73 MiB	2.26 MiB	550.35 KiB
80dcf36	1.72 MiB	2.28 MiB	570.67 KiB
418cd6d	1.72 MiB	2.28 MiB	570.44 KiB
19b506b	1.72 MiB	2.28 MiB	565.45 KiB
4e5eb0c	1.73 MiB	2.26 MiB	550.51 KiB
f79cd6a	1.72 MiB	2.28 MiB	570.44 KiB
f08b219	1.73 MiB	2.26 MiB	550.38 KiB

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (ba90bd9) 81.05% compared to head (247ceb3) 81.11%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2659      +/-   ##
============================================
+ Coverage     81.05%   81.11%   +0.05%     
- Complexity     4427     4449      +22     
============================================
  Files           345      345              
  Lines         16356    16407      +51     
  Branches       2219     2226       +7     
============================================
+ Hits          13258    13308      +50     
- Misses         2170     2172       +2     
+ Partials        928      927       -1     

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[marandaneto]

@stefanosiano should we close this then? #2158

[marandaneto]

@stefanosiano can you attach a screenshot of the result?

[stefanosiano]

@stefanosiano should we close this then? #2158

I think so. I wanted to use and expand that, but there were several differences, so I ended up creating a whole new pr

@stefanosiano can you attach a screenshot of the result?

Added it in the description

[romtsn]

After a quick glance looks good, but I'll defer to @markushi for proper review

[stefanosiano]

Let's update the span data keys to align with https://develop.sentry.dev/sdk/performance/span-data-conventions/

[marandaneto]

@stefanosiano can we actually add the children's span nested to its parents?
For example, secureConnect is a child of connect, etc.
Since you have the reference of each of them, it's possible, I recall @bruno-garcia asking this as well when I did the first PoC.

[stefanosiano]

@stefanosiano can we actually add the children's span nested to its parents? For example, secureConnect is a child of connect, etc. Since you have the reference of each of them, it's possible, I recall @bruno-garcia asking this as well when I did the first PoC.

Sure, i'll add it

[marandaneto]

@stefanosiano I've left a few names, there's a spec for crumbs and spans, let's use the very same keys as per spec.

[stefanosiano]

@marandaneto would you take another look?

[marandaneto]

Left a few more comments, if the maintainers are happy, I am happy.

[markushi]

@marandaneto could you unblock this PR - we want to merge and ship this today 😊

[marandaneto]

happy

It's not blocked, #2659 (review)
Only one approval is needed.

[romtsn]

happy

It's not blocked, #2659 (review) Only one approval is needed.

I think you have to approve it actually

if the maintainers are happy, I am happy.