feat: Add sentry-android sdk version check

[romtsn]

#skip-changelog

📜 Description

Add a sentry-android SDK version check in the projects.afterevaluate step

💡 Motivation and Context

This is necessary to avoid breaking customers' code at runtime, for instance, if they are using an older version of sentry-android which does not contain file I/O runtime classes. So we just disable the auto-instrumentation features based on the main SDK version

💚 How did you test it?

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• No breaking changes

🔮 Next steps

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 422a02c

[cortinico]

Sorry I came a bit late to the review :) Anyway I left some comments.

I'm also curious to know why is it needed to resolve a configuration to search for "sentry-android-core"? Is there a scenario where the Gradle Plugin can be applied to a project that doesn't also import the Android SDK? If so, why is this the case?

It would be way less error prone to just offer the possibility to add an implementation dependency to the Sentry Android SDK. Maybe this can be an opt-out feature, so the user could manually configure it if they wish.

This will simplify also the SentryAndroidSdkState and the isAtLeast as you already know the version of the Android SDK that is shipped with the Gradle Plugin.

[romtsn]

Sorry I came a bit late to the review :) Anyway I left some comments.

I'm also curious to know why is it needed to resolve a configuration to search for "sentry-android-core"? Is there a scenario where the Gradle Plugin can be applied to a project that doesn't also import the Android SDK? If so, why is this the case?

It would be way less error prone to just offer the possibility to add an implementation dependency to the Sentry Android SDK. Maybe this can be an opt-out feature, so the user could manually configure it if they wish.

This will simplify also the SentryAndroidSdkState and the isAtLeast as you already know the version of the Android SDK that is shipped with the Gradle Plugin.

Yeah, that's unlikely that SAGP would be used without the main Android SDK, but we are not solely checking for presence of the SDK here, but also the version. Based on the version we enable/disable bytecode manipulation features, which otherwise would crash the app at runtime, if we would be calling to some non-existing classes.

We thought of having SAGP applying the main SDK as a dependency, but that still cannot guarantee that the version won't be resolved by Gradle to a higher one (if there's one in the dependency tree), or that it can even be forced by the users to something else. This approach may be brittle, but seems the most failsafe one at least. We can't afford this on the SDK I believe as it will be crashing the end-users apps.

This can be a nice feature though, I think we will eventually end up having SAGP as a single integration point

[romtsn]

Submitted #250 to address your review @cortinico

[cortinico]

Thanks for the clarifications @romtsn 👍