-
-
Notifications
You must be signed in to change notification settings - Fork 32
enha: make root checker better and minimize false positive #417
Conversation
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage 60.18% 60.18%
Complexity 809 809
=========================================
Files 92 92
Lines 3747 3747
Branches 360 360
=========================================
Hits 2255 2255
Misses 1338 1338
Partials 154 154 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but wouldn't it be better to add tests for it?
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/util/RootChecker.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/util/RootChecker.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/util/RootChecker.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage 59.96% 59.96%
Complexity 812 812
=========================================
Files 93 93
Lines 3742 3742
Branches 363 363
=========================================
Hits 2244 2244
Misses 1343 1343
Partials 155 155 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it way more now. It would be super nice to just have one integration test on a real android device or a virtual device just to make sure everything is wired up properly, but that's up to you.
📢 Type of change
📜 Description
make root checker better and minimize false positive.
💡 Motivation and Context
I still could reproduce false positive on the current root checker
💚 How did you test it?
📝 Checklist
🔮 Next steps