fix(inject): Improve fixup_js_file #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Mar 17, 2023
| writeln!(js_contents, "{to_inject}")?; | ||
| writeln!(js_contents, "{DEBUGID_COMMENT_PREFIX}={debug_id}")?; | ||
|
|
||
| if let Some(sourcemap_comment) = sourcemap_comment { | ||
| write!(js_contents, "{sourcemap_comment}")?; | ||
| writeln!(js_contents, "{sourcemap_comment}")?; |
There was a problem hiding this comment.
just for context…
it might be the case that users are still post-processing stuff after a sentry-cli run, like blindly concatenating two files, in which case we would break as the first line of the concatenated file would be commented out, and the 2nd line would have a syntax error
Swatinem
approved these changes
Mar 17, 2023
|
I added a test that contains empty lines (to make sure that we're not semi-overwriting the previous contents due to skipping those) and makes a filesystem roundtrip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//# sourceMappingURLcomments (as is the case for one of our tests), the last one will be moved to the end of the file (after the injected content) and the others will be left alone. Previously, the others were deleted.