-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich every event with device and app context #1104
Labels
Comments
using an |
5 tasks
Instead of using an event processor, we could do this in prepare event sentry-cocoa/Sources/Sentry/SentryClient.m Line 418 in b1ce7c5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the
SentryCrashIntegration
configures theScope
of the currentHub
with the device and app data.sentry-cocoa/Sources/Sentry/SentryCrashIntegration.m
Lines 133 to 136 in b46bdab
This has the disadvantage when creating a
Hub
manually the client doesn't enrich the event with device and app data. Java uses an EventProcessor to achieve this.This came up because we made
Sentry.currentHub
private in 7.0.0 and a user used this method just to initialize a Hub with the scope of thecurrentHub
, see #434 (comment).The text was updated successfully, but these errors were encountered: