Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device free_memory isn't read at the time the event is captured #1824

Closed
bruno-garcia opened this issue May 11, 2022 · 2 comments · Fixed by #1962
Closed

Device free_memory isn't read at the time the event is captured #1824

bruno-garcia opened this issue May 11, 2022 · 2 comments · Fixed by #1962

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented May 11, 2022

Description

image

Since free_memory is set on the scope when the SDK initializes, it doesn't accurately represent the free RAM at the time of the event.

It seems SentryCrash has the API that gives us this data. In which case it's likely it reads the data right before a crash. So possibly impact is just events captured at runtime (captureEvent, captureException, etc).

Data is put on scope here

[SentrySDK.currentHub configureScope:^(SentryScope *_Nonnull outerScope) {
[SentryCrashIntegration enrichScope:outerScope];

Related to #1104

@philipphofmann
Copy link
Member

Instead of using an event processor, we could do this in prepare event

- (SentryEvent *_Nullable)prepareEvent:(SentryEvent *)event

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants