Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send Locale with Events #1539

Merged
merged 1 commit into from
Dec 10, 2021
Merged

feat: Send Locale with Events #1539

merged 1 commit into from
Dec 10, 2021

Conversation

philipphofmann
Copy link
Member

📜 Description

Send the current locale with events. The SDK puts the locale into the device
context of the event.

💡 Motivation and Context

Fixes GH-1438

💚 How did you test it?

Unit tests and simulator.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Send the current locale with events. The SDK puts the locale into the device
context of the event.

Fixes GH-1438
@github-actions
Copy link

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1144518

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 6f65cc7 into master Dec 10, 2021
@philipphofmann philipphofmann deleted the feat/device-locale branch December 10, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send device locale with Events
2 participants