-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send device locale with Events #1438
Comments
Android offers |
Sync with getsentry/sentry#29879. |
None of our events in our Sentry main project has a Todos:
Culture Conext
|
Turns out we added this under a new Context called
This is a breaking change since these values are indexed and used to show distribution and potentially alerts. Do we need to change from one to the other? If so, what ISO format are we going from, to? |
|
Who said that ⬆️ ? I don't think |
@philipphofmann that was just the natural way going forward after adding
|
Why don't the develop docs then state that they are deprecated? It doesn't help to decide this in the PR and not putting this in the docs. If the official decision is they are deprecated we should communicate that on the docs.
Sorry, I don't get that. Are you saying we should index it? If so, deciding in getsentry/develop#329 to use |
@philipphofmann please invite us for a call, its easier |
Send the current locale with events. The SDK puts the locale into the device context of the event. Fixes GH-1438
Send the current locale with events. The SDK puts the locale into the device context of the event. Fixes GH-1438
Discover lists
device.locale
as a search condition, see https://docs.sentry.io/product/discover-queries/query-builder/. The develop docs list thelocale
in culture context, see https://develop.sentry.dev/sdk/event-payloads/contexts/#culture-context. Figure out how to send the device locale so customers can use it in Discover. After this maybe fix the Discover or Develop docs and create an issue for the Java repo.The text was updated successfully, but these errors were encountered: