ref: Remove unused SentryCrashDeadlock #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With #1906, we have our own solution of detecting app hangs. We can remove the unused SentryCrash deadlock detection.
armcknight
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
I think we should also remove this line: https://github.com/getsentry/sentry-cocoa/blob/master/Tests/ThreadSanitizer.sup#L12.
kevinrenskers
added a commit
that referenced
this pull request
Jul 8, 2022
* master: build: Remove trailing-whitespace (#1953) ci: Compile iOS13-Swift sample (#1951) release: 7.20.0 meta: Fix changelog (#1950) feat: Add sample rate in the baggage header, remove Userid and Transaction (#1936) build: Upate Brewfile.lock and Gemfile.lock (#1947) meta: Add Pre Commit Hook (#1946) ref: Remove unused SentryCrashDeadlock (#1941) feat: Add screenshot at crash (#1920) Add code docs for SentryScope (#1942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
With #1906, we have our own solution for detecting app hangs. We can remove
the unused SentryCrash deadlock detection.
#skip-changelog
馃挕 Motivation and Context
Remove unused code.
馃挌 How did you test it?
CI.
馃摑 Checklist
馃敭 Next steps