meta: Add Pre Commit Hook #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pre commit to call clang-format and a couple of other checks.
|
BTW, I think rbenv should be added to the Brewfile. I didn't have it installed for example, and it stopped |
brustolin
approved these changes
Jul 7, 2022
kevinrenskers
added a commit
that referenced
this pull request
Jul 7, 2022
* master: meta: Add Pre Commit Hook (#1946)
armcknight
reviewed
Jul 7, 2022
Comment on lines
+1
to
+11
| init: setup-git | ||
| which brew || /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" | ||
| brew bundle | ||
| rbenv install --skip-existing | ||
| rbenv exec gem update bundler | ||
| rbenv exec bundle update | ||
| cd Samples/TrendingMovies && carthage update --use-xcframeworks | ||
|
|
||
| setup-git: | ||
| ifneq (, $(shell which pre-commit)) | ||
| pre-commit install |
There was a problem hiding this comment.
This setup won't work on new systems. We need to add pre-commit to Brewfile, otherwise it'll never be installed, and setup-git will never install the hooks. Also, I think it'd be better to avoid the dependency indirection and which check, by putting pre-commit install directly into make init after brew bundle.
There was a problem hiding this comment.
It got added to the Brewfile in #1947
kevinrenskers
added a commit
that referenced
this pull request
Jul 8, 2022
* master: build: Remove trailing-whitespace (#1953) ci: Compile iOS13-Swift sample (#1951) release: 7.20.0 meta: Fix changelog (#1950) feat: Add sample rate in the baggage header, remove Userid and Transaction (#1936) build: Upate Brewfile.lock and Gemfile.lock (#1947) meta: Add Pre Commit Hook (#1946) ref: Remove unused SentryCrashDeadlock (#1941) feat: Add screenshot at crash (#1920) Add code docs for SentryScope (#1942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-commit to call clang-format and a couple
of other checks.
#skip-changelog