Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash in profiling logger #1964

Merged
merged 3 commits into from
Jul 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Properly sanitize the event context and SDK information (#1943)
- Don't send error 429 as `network_error` (#1957)
- Deprecate not needed option `sdkInfo` (#1960)
- Crash in profiling logger (#1964)

## 7.20.0

Expand Down
6 changes: 3 additions & 3 deletions Sources/Sentry/SentryProfilingLogging.mm
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
}
va_list args;
va_start(args, fmt);
va_end(args);
const auto fmtStr = [[NSString alloc] initWithUTF8String:fmt];
[SentryLog logWithMessage:[[NSString alloc] initWithFormat:fmtStr arguments:args]
andLevel:sentryLevelFromLogLevel(level)];
const auto msgStr = [[NSString alloc] initWithFormat:fmtStr arguments:args];
va_end(args);
[SentryLog logWithMessage:msgStr andLevel:sentryLevelFromLogLevel(level)];
}

} // namespace profiling
Expand Down