Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Crash in profiling logger #1964

Merged
merged 3 commits into from
Jul 12, 2022
Merged

fix: Crash in profiling logger #1964

merged 3 commits into from
Jul 12, 2022

Conversation

indragiek
Copy link
Member

馃摐 Description

Call va_end after creating the NSString *, otherwise this is undefined behavior and can crash.

馃挕 Motivation and Context

Customer reported a crash:

image

馃挌 How did you test it?

Manually verified that logging still works, we will deploy the fix and ask the customer to check whether this resolves their issue.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

馃敭 Next steps

@indragiek indragiek changed the title fix: Fix crash in profiling logger fix: Crash in profiling logger Jul 12, 2022
armcknight
armcknight approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃 馃憖

@indragiek indragiek merged commit ce1b8d1 into master Jul 12, 2022
@indragiek indragiek deleted the indragiek/fix-log-crash branch July 12, 2022 21:20
kevinrenskers added a commit that referenced this pull request Jul 13, 2022
@kevinrenskers
Merge branch 'master' into fix/1824-read-free-memory-at-time-of-event
56c19a7 
* master:
  fix: Crash in profiling logger (#1964)
  ref: Mark options.sdkInfo as deprecated (#1960)
  feat: Add extra app start span (#1952)
kevinrenskers added a commit that referenced this pull request Jul 13, 2022
@kevinrenskers
Merge branch 'master' into fix/1307-sanitze-span
c20efe8 
* master:
  fix: Crash in profiling logger (#1964)
  ref: Mark options.sdkInfo as deprecated (#1960)
  feat: Add extra app start span (#1952)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armcknight armcknight armcknight approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann

@brustolin brustolin Awaiting requested review from brustolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@indragiek @armcknight @getsentry-bot