Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VisionOS Support for Carthage #3565

Merged
merged 7 commits into from Jan 29, 2024
Merged

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 22, 2024

📜 Description

Fix Sources/Configuration/SDK.xcconfig by removing the workaround added with #491 so CI can build Carthage XCFrameworks to include VisionOS. The workaround seems to be fixed with Carthage/Carthage#3001 in Carthage 0.35.0 released in Jun 2020. Therefore, we can remove the SDKROOT__CARTHAGE settings in Sources/Configuration/SDK.xcconfig, which caused problems when building the SDK for visionOS see #3410 (comment). We never removed the workaround #491, as it didn't cause any problems.

Furthermore, bump pre-commit action https://github.com/python-jsonschema/check-jsonschema to 0.27.3, so it allows macos-13-xlarge as a valid runner.

Blocked by actions/runner-images#9170 to remove Xcode 15.2 beta.

Docs PR getsentry/sentry-docs#8917.

💡 Motivation and Context

Fixes GH-3410

💚 How did you test it?

CI see https://github.com/getsentry/sentry-cocoa/actions/runs/7611542267/job/20727218796.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@philipphofmann philipphofmann changed the title Feat/visionos carthage Add VisionOS Support for Carthage Jan 22, 2024
Copy link

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 20b1594

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42ef6ba) 89.244% compared to head (20b1594) 89.250%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3565       +/-   ##
=============================================
+ Coverage   89.244%   89.250%   +0.006%     
=============================================
  Files          529       529               
  Lines        57689     57648       -41     
  Branches     20641     20625       -16     
=============================================
- Hits         51484     51451       -33     
+ Misses        5292      5289        -3     
+ Partials       913       908        -5     

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ef6ba...20b1594. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.78 ms 1223.06 ms 8.29 ms
Size 21.58 KiB 417.86 KiB 396.28 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4be2b3c 1220.47 ms 1223.88 ms 3.41 ms
8e76be4 1272.67 ms 1286.38 ms 13.71 ms
1734d1b 1198.69 ms 1221.62 ms 22.93 ms
bef2003 1248.18 ms 1258.86 ms 10.68 ms
6e342ac 1216.02 ms 1232.88 ms 16.86 ms
f797112 1247.41 ms 1261.30 ms 13.89 ms
e998fd0 1254.41 ms 1272.78 ms 18.37 ms
98a8c16 1206.40 ms 1232.14 ms 25.74 ms
1db04d8 1250.20 ms 1258.12 ms 7.92 ms
ed68562 1229.16 ms 1248.74 ms 19.58 ms

App size

Revision Plain With Sentry Diff
4be2b3c 20.76 KiB 393.37 KiB 372.61 KiB
8e76be4 20.76 KiB 427.66 KiB 406.89 KiB
1734d1b 21.58 KiB 418.82 KiB 397.24 KiB
bef2003 22.85 KiB 407.73 KiB 384.88 KiB
6e342ac 20.76 KiB 436.66 KiB 415.90 KiB
f797112 20.76 KiB 434.94 KiB 414.18 KiB
e998fd0 21.58 KiB 414.59 KiB 393.01 KiB
98a8c16 20.76 KiB 431.00 KiB 410.24 KiB
1db04d8 20.76 KiB 435.50 KiB 414.74 KiB
ed68562 22.84 KiB 403.24 KiB 380.39 KiB

@philipphofmann philipphofmann marked this pull request as ready for review January 22, 2024 13:36
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann
Copy link
Member Author

actions/runner-images#9170 got merged. Xcode 15.2 is no longer beta see: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-arm64-Readme.md. We can merge this.

@philipphofmann philipphofmann merged commit 8e5919b into main Jan 29, 2024
76 of 77 checks passed
@philipphofmann philipphofmann deleted the feat/visionos-carthage branch January 29, 2024 08:19
philipphofmann added a commit to getsentry/sentry-docs that referenced this pull request Feb 5, 2024
philipphofmann added a commit to getsentry/sentry-docs that referenced this pull request Feb 6, 2024
Related Cocoa PR getsentry/sentry-cocoa#3565.

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VisionOS Support for Carthage
2 participants