Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): Carthage visionOS support #8917

Closed
wants to merge 2 commits into from

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 22, 2024

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Related Cocoa PR getsentry/sentry-cocoa#3565.

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 8:25am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 8:25am

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lizokm
Copy link
Contributor

lizokm commented Feb 2, 2024

Hey there, @philipphofmann! Since we've moved docs over to Next.js, if this PR is still relevant, could you rewrite it please? (Nothing has changed in the docs contribution process other than that we have to add images/PDFs to the"public" folder for them to be visible.) Thanks and sorry for the extra work!

@philipphofmann
Copy link
Member Author

That's not a problem. Where are the Next.js docs?

@lizokm
Copy link
Contributor

lizokm commented Feb 2, 2024

Thank you, @philipphofmann! Next.js has taken over Gatsby and lives in the same repo where Gatsby used to live. So nothing has really changed and you can still use your code editor of choice :) It's just that none of the unstaged changes will be visible in the new Next.js docs, which is why you have to rewrite them.

@philipphofmann
Copy link
Member Author

OK got it. Here we go #9047.

@philipphofmann philipphofmann deleted the feat/carthage-vision-os branch February 5, 2024 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants