fix: Support clearing user with null on iOS native bridge #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
force-pushed
the
jenn/event-origin-tag
branch
from
2bd2b63
to
b78c5e7
Compare
jennmueng
force-pushed
the
jenn/ios-set-user-fix
branch
from
ddc7f10
to
8922721
Compare
jennmueng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cordova passes the values as
NSNulland notnillike on React Native.Fixes #203
Testing:
Tested on Cordova sample app that after setting the user on the scope, calling
setUseron the JS layer withnullclears the user on iOS in a native crash.