Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : expect a sdkName based on the test platform #112

Merged
merged 5 commits into from Oct 14, 2020
Merged

Conversation

rxlabz
Copy link
Contributor

@rxlabz rxlabz commented Oct 14, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

  • define the sdkname based on the platform in the test
  • fix the GitHub action to run pub run test . instead of pub run test test/*

馃挕 Motivation and Context

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

馃敭 Next steps

@rxlabz rxlabz marked this pull request as ready for review October 14, 2020 09:45
.github/workflows/dart.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxlabz rxlabz merged commit fe54d44 into main Oct 14, 2020
@rxlabz rxlabz deleted the fix/sdkname-test branch October 14, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants