Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : expect a sdkName based on the test platform #112

Merged
merged 5 commits into from
Oct 14, 2020
Merged

fix : expect a sdkName based on the test platform #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cc0762
fix : expect a sdkName based on the test platform
rxlabz Oct 14, 2020
ab0c3a0
changelog
rxlabz Oct 14, 2020
c9ebdb8
changelog
rxlabz Oct 14, 2020
6d7e59b
fix the main not found error
rxlabz Oct 14, 2020
4db6a0d
fix changelog and dart worklow test directory
rxlabz Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- uses: actions/checkout@v2
- run: pub get
- name: Test on Chrome
run: pub run test -p chrome test/*
run: pub run test -p chrome test
- run: dartanalyzer --fatal-warnings ./
- run: dartfmt -n --set-exit-if-changed ./
package-analysis:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- new Dart code file structure #96
- Base the sdk name on the platform (`sentry.dart` for io & flutter, `sentry.dart.browser` in a browser context) #103
- Single changelog and readme for both packages #105
- expect a sdkName based on the test platform #105

# `package:sentry` changelog

Expand Down
3 changes: 3 additions & 0 deletions dart/test/test_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const String _testDsnWithPort =
void testHeaders(
Map<String, String> headers,
ClockProvider fakeClockProvider, {
String sdkName,
bool withUserAgent = true,
bool compressPayload = true,
bool withSecret = true,
Expand Down Expand Up @@ -98,6 +99,7 @@ Future testCaptureException(
fakeClockProvider,
compressPayload: compressPayload,
withUserAgent: !isWeb,
sdkName: isWeb ? browserSdkName : sdkName,
);

Map<String, dynamic> data;
Expand Down Expand Up @@ -256,6 +258,7 @@ void runTest({Codec<List<int>, List<int>> gzip, bool isWeb = false}) {
withUserAgent: !isWeb,
compressPayload: false,
withSecret: false,
sdkName: isWeb ? browserSdkName : sdkName,
);

await client.close();
Expand Down