Discard empty stack frames

[denrase]

📜 Description

Filter out stack frames that are empty.

💡 Motivation and Context

Closes #1570

💚 How did you test it?

Unit tests. Check on sentry.io

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
• I updated the docs if needed
• All tests passing
• No breaking changes

[codecov]

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
sqflite/lib/src/sentry_database.dart	100.00%

📢 Thoughts on this report? Let us know!.

[denrase]

@ueman Would you be so kind to check if this solves your issue?

[github-actions]

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	332.44 ms	395.04 ms	62.60 ms
Size	6.16 MiB	7.14 MiB	1010.89 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
43760f9	321.78 ms	366.77 ms	44.99 ms
f4cc744	349.53 ms	394.68 ms	45.15 ms
e5b744f	302.70 ms	342.17 ms	39.47 ms
3637a22	322.59 ms	390.00 ms	67.41 ms
ccc09e4	308.21 ms	357.74 ms	49.54 ms
633cf2e	289.36 ms	340.38 ms	51.02 ms
2331d89	352.45 ms	417.34 ms	64.89 ms
abcdba3	354.68 ms	399.04 ms	44.36 ms
f79eecf	341.35 ms	388.98 ms	47.63 ms
322aa66	284.98 ms	341.76 ms	56.78 ms

App size

Revision	Plain	With Sentry	Diff
43760f9	6.15 MiB	7.13 MiB	1000.49 KiB
f4cc744	5.94 MiB	6.95 MiB	1.01 MiB
e5b744f	6.06 MiB	7.09 MiB	1.03 MiB
3637a22	6.06 MiB	7.09 MiB	1.03 MiB
ccc09e4	5.94 MiB	6.95 MiB	1.01 MiB
633cf2e	5.94 MiB	6.92 MiB	1001.53 KiB
2331d89	5.94 MiB	6.96 MiB	1.02 MiB
abcdba3	5.94 MiB	6.95 MiB	1.01 MiB
f79eecf	6.15 MiB	7.13 MiB	1000.07 KiB
322aa66	5.94 MiB	6.92 MiB	1005.75 KiB

Previous results on branch: fix/discard-empty-stack-frames

Startup times

Revision	Plain	With Sentry	Diff
e74241a	333.35 ms	389.15 ms	55.79 ms
27e1631	337.52 ms	409.94 ms	72.42 ms
ee4d4b2	299.81 ms	348.90 ms	49.08 ms
a863aeb	311.34 ms	377.34 ms	66.00 ms

App size

Revision	Plain	With Sentry	Diff
e74241a	6.16 MiB	7.14 MiB	1010.90 KiB
27e1631	6.16 MiB	7.14 MiB	1010.91 KiB
ee4d4b2	6.16 MiB	7.14 MiB	1010.28 KiB
a863aeb	6.16 MiB	7.14 MiB	1010.20 KiB

[github-actions]

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1260.08 ms	1268.22 ms	8.14 ms
Size	8.29 MiB	9.39 MiB	1.10 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
1d47eb7	1212.57 ms	1222.00 ms	9.43 ms
7ade5af	1296.24 ms	1297.43 ms	1.18 ms
d189e01	1219.94 ms	1228.20 ms	8.27 ms
0aaa46e	1256.39 ms	1276.41 ms	20.02 ms
0ac1eed	1278.51 ms	1285.29 ms	6.78 ms
5aab4c5	1247.08 ms	1271.17 ms	24.09 ms
40680d3	1243.22 ms	1257.02 ms	13.80 ms
c1bb00f	1265.14 ms	1290.85 ms	25.71 ms
2331d89	1260.86 ms	1281.24 ms	20.39 ms
8d64376	1260.92 ms	1289.32 ms	28.40 ms

App size

Revision	Plain	With Sentry	Diff
1d47eb7	8.29 MiB	9.39 MiB	1.09 MiB
7ade5af	8.15 MiB	9.15 MiB	1015.93 KiB
d189e01	8.29 MiB	9.38 MiB	1.09 MiB
0aaa46e	8.29 MiB	9.38 MiB	1.09 MiB
0ac1eed	8.10 MiB	9.16 MiB	1.07 MiB
5aab4c5	8.10 MiB	9.16 MiB	1.07 MiB
40680d3	8.10 MiB	9.16 MiB	1.07 MiB
c1bb00f	8.09 MiB	9.07 MiB	1001.06 KiB
2331d89	8.16 MiB	9.17 MiB	1.01 MiB
8d64376	8.16 MiB	9.17 MiB	1.01 MiB

Previous results on branch: fix/discard-empty-stack-frames

Startup times

Revision	Plain	With Sentry	Diff
27e1631	1237.00 ms	1249.69 ms	12.69 ms
a863aeb	1273.55 ms	1282.92 ms	9.37 ms
ee4d4b2	1247.20 ms	1258.53 ms	11.33 ms
e74241a	1265.08 ms	1289.24 ms	24.16 ms

App size

Revision	Plain	With Sentry	Diff
27e1631	8.29 MiB	9.39 MiB	1.10 MiB
a863aeb	8.29 MiB	9.38 MiB	1.09 MiB
ee4d4b2	8.29 MiB	9.38 MiB	1.09 MiB
e74241a	8.29 MiB	9.39 MiB	1.10 MiB

[ueman]

@denrase I'll try to get to it tomorrow 👍

[ueman]

The problematic PlatformException looks like this when printed to console. Unfortunately, I can't reproduce it on my devices, but I found this in the breadcrumbs. Interestingly enough, there's no empty frame, so I assume there's still something else wrong with the current algorithm.

PlatformException(error, Unsupported value: '[Ljava.lang.StackTraceElement;@42f1d34' of type 'class [Ljava.lang.StackTraceElement;', null, java.lang.IllegalArgumentException: Unsupported value: '[Ljava.lang.StackTraceElement;@42f1d34' of type 'class [Ljava.lang.StackTraceElement;'
	at m9.q.p(StandardMessageCodec.java:67)
	at m9.r.c(StandardMethodCodec.java:7)
	at m9.j$a$a.error(MethodChannel.java:1)
	at com.dexterous.flutterlocalnotifications.FlutterLocalNotificationsPlugin.getNotificationChannels(FlutterLocalNotificationsPlugin.java:9)
	at com.dexterous.flutterlocalnotifications.FlutterLocalNotificationsPlugin.onMethodCall(FlutterLocalNotificationsPlugin.java:21)
	at m9.j$a.a(MethodChannel.java:2)
	at z8.c.l(DartMessenger.java:2)
	at z8.c.m(DartMessenger.java:3)
	at z8.c.i(Unknown Source:0)
	at z8.b.run(Unknown Source:12)
	at android.os.Handler.handleCallback(Handler.java:955)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:228)
	at android.app.ActivityThread.main(ActivityThread.java:9105)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:614)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1129)
)

For convenience, here's just the Java stacktrace:

java.lang.IllegalArgumentException: Unsupported value: '[Ljava.lang.StackTraceElement;@42f1d34' of type 'class [Ljava.lang.StackTraceElement;'
	at m9.q.p(StandardMessageCodec.java:67)
	at m9.r.c(StandardMethodCodec.java:7)
	at m9.j$a$a.error(MethodChannel.java:1)
	at com.dexterous.flutterlocalnotifications.FlutterLocalNotificationsPlugin.getNotificationChannels(FlutterLocalNotificationsPlugin.java:9)
	at com.dexterous.flutterlocalnotifications.FlutterLocalNotificationsPlugin.onMethodCall(FlutterLocalNotificationsPlugin.java:21)
	at m9.j$a.a(MethodChannel.java:2)
	at z8.c.l(DartMessenger.java:2)
	at z8.c.m(DartMessenger.java:3)
	at z8.c.i(Unknown Source:0)
	at z8.b.run(Unknown Source:12)
	at android.os.Handler.handleCallback(Handler.java:955)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:228)
	at android.app.ActivityThread.main(ActivityThread.java:9105)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:614)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1129)

Maybe there's even just an issue with a trailing newline? The closing ) of the exception is on itss own line, which could be an indicator for that? Comparing the stacktrace to the screenshot of the issues seems to indicate that there's nothing missing, so the empty line seems to be superflouos.

[ueman]

Thank you for fixing this. LGTM 🎉