Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(javascript): Add CDN bundle example for performance #2039

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

benvinegar
Copy link
Contributor

Instructions are now tabbed between ESM and CDN.

@benvinegar benvinegar requested a review from a team as a code owner August 20, 2020 05:01
@vercel
Copy link

vercel bot commented Aug 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/mg460r202/sentry.dev
✅ Preview: https://sentry-docs-git-feat-perf-cdn-example.sentry.dev

# Using yarn
$ yarn add @sentry/browser @sentry/tracing

# Using npm
$ npm install @sentry/browser @sentry/tracing
```

Alternatively, instead of `npm` packages, you can use our pre-built CDN bundle that combines both `@sentry/browser` and `@sentry/tracing`:

<JsCdnTag apm={true} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure how to get the tabbed experience while using this <JsCdnTag/> component. Open to ideas if someone can direct me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for anyone else: you cant, what ben did here is the right solution

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Haven't tried using tags+tabs yet, maybe Cramer will be best bet if there's a better way to do it.

I noticed the Vercel deployment is kinda broken, every page loads and after a quick blink renders nothing but Loading (StaticQuery). Guessing it is unrelated to the changes here.

@dcramer
Copy link
Member

dcramer commented Aug 21, 2020

im gonna update this and merge

@dcramer dcramer merged commit 82feef3 into master Aug 21, 2020
@dcramer dcramer deleted the feat/perf-cdn-example branch August 21, 2020 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants