Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(feedback): remove beta banners and 'associated error event' mentions #9985

Merged
merged 3 commits into from
May 10, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented May 9, 2024

As of this week User Feedback has been GA'd and is the primary way of submitting feedback!

The old method, user reports, required an associated error event but this method does not. So when describing the widget/overall product, the mentions of associating events are incorrect.


Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:44pm

@aliu39 aliu39 requested review from a team and jas-kas May 9, 2024 19:31
Copy link

codecov bot commented May 9, 2024

Bundle Report

Changes will decrease total bundle size by 195 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.43MB 184 bytes ⬇️
sentry-docs-edge-server 458.51kB 3 bytes ⬇️
sentry-docs-client 6.16MB 8 bytes ⬇️

@@ -1,5 +0,0 @@
<Note title="A Wild User Feedback Appears!">

Sentry released a new version of User Feedback that supports collecting feedback at any time from your users, without requiring an error event. It is currently in open beta and subject to change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we can re-utilize this to say UF is in GA now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh a banner for that could be nice! Maybe add in a new file + PR though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could :o Not something we've done in the past for docs though, so I'd make sure to get the docs teams eyes on it for their opinion

@jas-kas
Copy link
Member

jas-kas commented May 10, 2024

Looks good to me! Checked the Vercel preview for both User Feedback pages in docs. :)

@aliu39 aliu39 requested a review from a team May 10, 2024 16:37
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping the docs updated!

docs/platforms/javascript/common/user-feedback/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@aliu39 aliu39 merged commit 848dbe3 into master May 10, 2024
6 checks passed
@aliu39 aliu39 deleted the aliu/widget-docs branch May 10, 2024 20:26
antonpirker pushed a commit that referenced this pull request May 14, 2024
…ons (#9985)

* doc(feedback): remove beta banners and 'associated error event' mentions

* Delete beta note file

* Update docs/platforms/javascript/common/user-feedback/index.mdx

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>

---------

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants