Skip to content

Commit

Permalink
Removed IAsyncDisposable from CachingTransport (#3179)
Browse files Browse the repository at this point in the history
  • Loading branch information
jamescrosswell committed Mar 4, 2024
1 parent d43c1de commit d64358e
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/Sentry/Internal/Http/CachingTransport.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@

namespace Sentry.Internal.Http;

internal class CachingTransport : ITransport, IAsyncDisposable, IDisposable
/// <summary>
/// A transport that caches envelopes to disk and sends them in the background.
/// </summary>
/// <remarks>
/// Note although this class has a <see cref="CachingTransport.DisposeAsync"/>
/// method, it doesn't implement <see cref="IAsyncDisposable"/> as this caused
/// a dependency issue with Log4Net in some situations.
///
/// See https://github.com/getsentry/sentry-dotnet/issues/3178
/// </remarks>
internal class CachingTransport : ITransport, IDisposable
{
private const string EnvelopeFileExt = "envelope";

Expand Down

0 comments on commit d64358e

Please sign in to comment.